Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field title fixes #1549

Merged
merged 4 commits into from
Oct 16, 2023
Merged

Field title fixes #1549

merged 4 commits into from
Oct 16, 2023

Conversation

VargaJoe
Copy link
Contributor

No description provided.

@VargaJoe VargaJoe marked this pull request as ready for review October 13, 2023 15:12
@sensenet
Copy link

sensenet bot commented Oct 13, 2023 •
edited
Loading

Site name Url Last deploy
sn-react-component-docs-dev https://652989c5b9951d09e2913c2b--sn-react-component-docs-dev.netlify.app Fri Oct 13 2023 - 18:17:41 GMT+0000 (Coordinated Universal Time)
sn-app-dev https://652989df44099d0c594624de--sn-app-dev.netlify.app Fri Oct 13 2023 - 18:18:07 GMT+0000 (Coordinated Universal Time)

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9a6c73a) 92.52% compared to head (f977e7a) 92.52%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1549   +/-   ##
========================================
  Coverage    92.52%   92.52%           
========================================
  Files          250      250           
  Lines         7059     7059           
  Branches      1913     1913           
========================================
  Hits          6531     6531           
  Misses         528      528
Files Coverage Δ
...n-controls-react/src/fieldcontrols/date-picker.tsx 98.03% <ø> (ø)
...controls-react/src/fieldcontrols/dropdown-list.tsx 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tusmester tusmester merged commit 83d13f1 into develop Oct 16, 2023
7 checks passed
@tusmester tusmester deleted the fix/field-title-fixes branch October 16, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tusmester tusmester tusmester approved these changes

@hassanad94 hassanad94 Awaiting requested review from hassanad94

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VargaJoe @tusmester